Changeset 277

Timestamp:

10/28/08 17:30:09 (2 months ago)

Author:

tal

Message:

Several improvements:
- Cells are only drawn if they are visible.
- Added a preloadGlyphCellImages methods.
- Fixed a click bug on the first cell in the view.

Files:

• packages/defconAppKit/trunk/Lib/defconAppKit/views/glyphCellView.py (modified) (7 diffs)

packages/defconAppKit/trunk/Lib/defconAppKit/views/glyphCellView.py

@@ -114 +114 @@
-        self._glyphDetailOnMouseMoved = False
-
+        self._windowIsClosed = False
+
-        return self
-
@@ -122 +124 @@
-    def setAllowsDrag_(self, value):
-        self._allowDrag = value
+
+    def preloadGlyphCellImages(self):
+        representationName = self._cellRepresentationName
+        representationArguments = self._cellRepresentationArguments
+        cellWidth = self._cellWidth
+        cellHeight = self._cellHeight
+        for glyph in self._glyphs:
+            glyph.getRepresentation(representationName, width=cellWidth, height=cellHeight, **representationArguments)
-
-    def setGlyphs_(self, glyphs):
@@ -221 +231 @@
-
-    def windowCloseNotification_(self, notification):
+        self._windowIsClosed = True
-        if self._glyphDetailWindow is not None:
-            if self._glyphDetailWindow.getNSWindow() is not None:
@@ -272 +283 @@
-        self._indexToClickRects = {}
-
+        visibleRect = self.visibleRect()
+
-        NSColor.whiteColor().set()
-        for index, glyph in enumerate(self._glyphs):
@@ -282 +295 @@
-            self._indexToClickRects[index] = rect
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
-
-            left += cellWidth
@@ -299 +313 @@
-
-        path = NSBezierPath.bezierPath()
-
++1
-            top = (i * cellHeight) - .5
-            path.moveToPoint_((0, top))
-            path.lineToPoint_((width, top))
-
++1
-            left = (i * cellWidth) - .5
-            path.moveToPoint_((left, 0))
@@ -383 +397 @@
-    def _handleDetailWindow(self, event, found, mouseDown=False, mouseMoved=False, mouseDragged=False, mouseUp=False, inDragAndDrop=False):
-        # no window
+        if self._windowIsClosed:
+            return
-        if self._glyphDetailWindow is None:
-            return