Changeset 181

Show
Ignore:
Timestamp:
04/12/08 08:04:07 (9 months ago)
Author:
tal
Message:
Removed the ignore arg in GSUB type 6. If the replacement is None, it is an ignore. That should be clear enough.
Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • packages/feaTools/trunk/Lib/feaTools/parser.py

    r180 r181  
    488488        counter += 1 
    489489        targetText = targetText[end:] 
    490     writer.gsubType6(precedingContext, extractedTargets, trailingContext, replacement, ignore=ignore
     490    writer.gsubType6(precedingContext, extractedTargets, trailingContext, replacement
    491491 
    492492def _parsePosType1(writer, target, value): 
  • packages/feaTools/trunk/Lib/feaTools/test.py

    r180 r181  
    4040        self._instructions.append(("gsub type 4", (target, replacement))) 
    4141 
    42     def gsubType6(self, precedingContext, target, trailingContext, replacement, ignore=False): 
    43         self._instructions.append(("gsub type 6", (precedingContext, target, trailingContext, replacement, ignore))) 
     42    def gsubType6(self, precedingContext, target, trailingContext, replacement): 
     43        self._instructions.append(("gsub type 6", (precedingContext, target, trailingContext, replacement))) 
    4444 
    4545    def gposType1(self, target, value): 
     
    439439        result = writer.getData() 
    440440        expected = [ 
    441                 ("gsub type 6", (["f"], ["o"], [], "o.alt", False)) 
     441                ("gsub type 6", (["f"], ["o"], [], "o.alt")) 
    442442                ] 
    443443        self.assertEqual(result, expected) 
     
    448448        result = writer.getData() 
    449449        expected = [ 
    450                 ("gsub type 6", (["f"], ["o"], ["o"], "o.alt", False)) 
     450                ("gsub type 6", (["f"], ["o"], ["o"], "o.alt")) 
    451451                ] 
    452452        self.assertEqual(result, expected) 
     
    457457        result = writer.getData() 
    458458        expected = [ 
    459                 ("gsub type 6", (["f"], ["o", "o"], [], "o_o.alt", False)) 
     459                ("gsub type 6", (["f"], ["o", "o"], [], "o_o.alt")) 
    460460                ] 
    461461        self.assertEqual(result, expected) 
     
    466466        result = writer.getData() 
    467467        expected = [ 
    468                 ("gsub type 6", (["f"], ["o", "o"], ["b"], "o_o.alt", False)) 
     468                ("gsub type 6", (["f"], ["o", "o"], ["b"], "o_o.alt")) 
    469469                ] 
    470470        self.assertEqual(result, expected) 
     
    476476        #result = writer.getData() 
    477477        #expected = [ 
    478         #        ("gsub type 6", ([["f"]], [["o"]], [["o"]], "o.alt", False)) 
     478        #        ("gsub type 6", ([["f"]], [["o"]], [["o"]], "o.alt")) 
    479479        #        ] 
    480480        #self.assertEqual(result, expected) 
     
    486486        result = writer.getData() 
    487487        expected = [ 
    488                 ("gsub type 6", ([], [["foo", "bar"]], ["bar"], ["foo.alt", "bar.alt"], False)) 
     488                ("gsub type 6", ([], [["foo", "bar"]], ["bar"], ["foo.alt", "bar.alt"])) 
    489489                ] 
    490490        self.assertEqual(result, expected) 
     
    497497        result = writer.getData() 
    498498        expected = [ 
    499                 ("gsub type 6", (["f"], ["o"], [], None, True)) 
     499                ("gsub type 6", (["f"], ["o"], [], None)) 
    500500                ] 
    501501        self.assertEqual(result, expected) 
     
    506506        result = writer.getData() 
    507507        expected = [ 
    508                 ("gsub type 6", (["f"], ["o"], ["o"], None, True)) 
     508                ("gsub type 6", (["f"], ["o"], ["o"], None)) 
    509509                ] 
    510510        self.assertEqual(result, expected) 
     
    515515        result = writer.getData() 
    516516        expected = [ 
    517                 ("gsub type 6", (["f"], ["o", "o"], [], None, True)) 
     517                ("gsub type 6", (["f"], ["o", "o"], [], None)) 
    518518                ] 
    519519        self.assertEqual(result, expected) 
     
    524524        result = writer.getData() 
    525525        expected = [ 
    526                 ("gsub type 6", (["f"], ["o", "o"], ["b"], None, True)) 
     526                ("gsub type 6", (["f"], ["o", "o"], ["b"], None)) 
    527527                ] 
    528528        self.assertEqual(result, expected) 
     
    533533        result = writer.getData() 
    534534        expected = [ 
    535                 ("gsub type 6", ([], [["foo", "bar"]], ["bar"], None, True)) 
     535                ("gsub type 6", ([], [["foo", "bar"]], ["bar"], None)) 
    536536                ] 
    537537        self.assertEqual(result, expected) 
  • packages/feaTools/trunk/Lib/feaTools/writers/baseWriter.py

    r180 r181  
    2525        raise NotImplementedError 
    2626 
    27     def gsubType6(self, precedingContext, target, trailingContext, replacement, ignore=False): 
     27    def gsubType6(self, precedingContext, target, trailingContext, replacement): 
    2828        raise NotImplementedError 
    2929 
  • packages/feaTools/trunk/Lib/feaTools/writers/fdkSyntaxWriter.py

    r171 r181  
    9898        self._instructions.append(t) 
    9999 
    100     def gsubType6(self, precedingContext, target, trailingContext, replacement, ignore=False): 
     100    def gsubType6(self, precedingContext, target, trailingContext, replacement): 
    101101        if isinstance(precedingContext, list): 
    102102            precedingContext = self._list2String(precedingContext) 
     
    108108        if isinstance(replacement, list): 
    109109            replacement = self._list2String(replacement) 
    110         if ignore: 
     110        # if the replacement is None, this is an "ignore" 
     111        if replacement is None: 
    111112            if precedingContext and trailingContext: 
    112113                t = "ignore sub %s %s %s;" % (precedingContext, target, trailingContext) 
     
    117118            else: 
    118119                t = "ignore sub %s;" % target 
     120        # otherwise it is a regular substitution 
    119121        else: 
    120122            if precedingContext and trailingContext: